Add back the mime renderer JL extension #5096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marthacryan
changed the title
marthacryan
force-pushed
the
notebook-connected-default
branch
from
f942e97 to
847b87c
Compare
|
Pinning the version of shapely here for tests to pass, but we should address that in another PR. |
Done! Want to take a quick look to see if it makes sense? |
emilykl
reviewed
Apr 15, 2025
Co-authored-by: Emily KL <[email protected]>
marthacryan
force-pushed
the
notebook-connected-default
branch
from
bcfbd25 to
f3a4278
Compare
emilykl
reviewed
Apr 15, 2025
.github/workflows/check-js-build.yml
Outdated
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| persist-credentials: false |
There was a problem hiding this comment.
good point. Also got that from the other script
emilykl
reviewed
Apr 15, 2025
emilykl
reviewed
Apr 15, 2025
emilykl
reviewed
Apr 15, 2025
Co-authored-by: Emily KL <[email protected]>
Update CONTRIBUTING.md
This was referenced Apr 17, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5056 by adding back a mime renderer extension removed in #4822. We didn't realize at the time that this part of the code was serving an important purpose in keeping filesizes down for offline users.